[geofencing-subscriptions]: Alignment on commonalities r2.3#311
Merged
bigludo7 merged 7 commits intocamaraproject:mainfrom Feb 27, 2025
Merged
Conversation
jlurien
requested changes
Feb 26, 2025
Collaborator
jlurien
left a comment
There was a problem hiding this comment.
The sinkCredential is to be removed only from the event. Most of the comments are related to removing it from the request.
7e68096 to
c4b4308
Compare
Contributor
Author
…g-subscriptions.yaml
…alities-r2.3 # Conflicts: # code/API_definitions/geofencing-subscriptions.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Aligns on Commonalities r2.3
Which issue(s) this PR fixes:
Fixes #302
Changelog input