Skip to content

[geofencing-subscriptions]: Alignment on commonalities r2.3#311

Merged
bigludo7 merged 7 commits intocamaraproject:mainfrom
maxl2287:alignment-on-commonalities-r2.3
Feb 27, 2025
Merged

[geofencing-subscriptions]: Alignment on commonalities r2.3#311
bigludo7 merged 7 commits intocamaraproject:mainfrom
maxl2287:alignment-on-commonalities-r2.3

Conversation

@maxl2287
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Aligns on Commonalities r2.3

Which issue(s) this PR fixes:

Fixes #302

Changelog input

 release-note
* [geofencing-subscriptions]: Alignment on commonalities r2.3

@maxl2287 maxl2287 self-assigned this Feb 25, 2025
@maxl2287 maxl2287 added correction Spring25 Meta-release Spring25 labels Feb 25, 2025
@maxl2287 maxl2287 marked this pull request as draft February 25, 2025 12:29
@maxl2287 maxl2287 marked this pull request as ready for review February 25, 2025 12:30
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sinkCredential is to be removed only from the event. Most of the comments are related to removing it from the request.

@maxl2287 maxl2287 closed this Feb 26, 2025
@maxl2287 maxl2287 force-pushed the alignment-on-commonalities-r2.3 branch from 7e68096 to c4b4308 Compare February 26, 2025 14:31
@maxl2287 maxl2287 reopened this Feb 27, 2025
@maxl2287 maxl2287 requested a review from jlurien February 27, 2025 09:02
@maxl2287
Copy link
Contributor Author

@jlurien sorry I have recorrected it and just removed the sinkCredential out of the response now.
Please review again
cc @bigludo7

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 merged commit f025dfc into camaraproject:main Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

correction Spring25 Meta-release Spring25

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align Geofencing-subscriptions on Commonalities r2.3

3 participants