Skip to content

Location verification align error tests#306

Merged
jlurien merged 4 commits intomainfrom
location-verification-align-error-tests
Feb 27, 2025
Merged

Location verification align error tests#306
jlurien merged 4 commits intomainfrom
location-verification-align-error-tests

Conversation

@jlurien
Copy link
Collaborator

@jlurien jlurien commented Feb 24, 2025

What type of PR is this?

  • tests

What this PR does / why we need it:

  • Adds a test scenario to cover 403 PERMISSION_DENIED
  • Adds test scenarios to cover specific 422 errors
  • Adapts scenario to return UNKNOWN
  • Removes 429 errors as explicitly documented in the OAS, as there is no specific logic for this API regarding those errors-

Which issue(s) this PR fixes:

Fixes #304

Special notes for reviewers:

404 NOT_FOUND is exceptionally kept in the spec even if there is no test for it

Changelog input

Test scenarios aligned with errors in spec

Additional documentation

This section can be blank.

docs

@github-actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 3 0 4.85s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.83s
✅ YAML yamllint 3 0 0.83s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@jlurien jlurien self-assigned this Feb 24, 2025
@jlurien jlurien added the Spring25 Meta-release Spring25 label Feb 24, 2025
bigludo7
bigludo7 previously approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maxl2287
maxl2287 previously approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@maxl2287 maxl2287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien jlurien dismissed stale reviews from maxl2287 and bigludo7 via ca36b27 February 25, 2025 11:58
@maxl2287 maxl2287 mentioned this pull request Feb 19, 2025
Closed
maxl2287
maxl2287 previously approved these changes Feb 27, 2025
View reviewed changes
@maxl2287 maxl2287 requested a review from bigludo7 February 27, 2025 09:27
bigludo7
bigludo7 previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien jlurien dismissed stale reviews from bigludo7 and maxl2287 via 312015f February 27, 2025 13:15
@jlurien jlurien merged commit 3700348 into main Feb 27, 2025
2 checks passed
@jlurien jlurien deleted the location-verification-align-error-tests branch September 1, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxl2287 maxl2287 maxl2287 approved these changes

@bigludo7 bigludo7 Awaiting requested review from bigludo7 bigludo7 is a code owner

Assignees

@jlurien jlurien

Labels

Spring25 Meta-release Spring25

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

location-verification: Align test plan with spec errors

3 participants

@jlurien @bigludo7 @maxl2287