Conversation
Collaborator
Author
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
|
|
||
| - Using preferably the authorisation code flow to obtain an access token, which will automatically identify the intended device. | ||
| - Identifying the intended device from a unique identifier for that device, such as its source IP address and port. | ||
| - Check with the SIM provider whether a unique "secondary" phone number is already associated with each device and use the secondary phone number to identify the intended device if available. |
Collaborator
There was a problem hiding this comment.
In line 74 we use the term API provider, but here we use SIM provider. Could we use a common term like service provider or opco ? Thank you.
maxl2287
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Current documentation omits the potential problem with phone numbers identifying a MultiSIM group. As there is no a single behaviour agreed in CAMARA yet, the proposed enhancement presents the problem and gives some hints to mitigate it
Which issue(s) this PR fixes:
Fixes #257
Special notes for reviewers:
Changelog input