Skip to content

[geofencing-subscriptions]: remove allOf in sinkCredential#265

Merged
maxl2287 merged 1 commit intocamaraproject:mainfrom
maxl2287:fix/remove-all-of-in-sinkcredential
Oct 15, 2024
Merged

[geofencing-subscriptions]: remove allOf in sinkCredential#265
maxl2287 merged 1 commit intocamaraproject:mainfrom
maxl2287:fix/remove-all-of-in-sinkcredential

Conversation

@maxl2287
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Removing this allOf aligns with the Commonalities latest version.
It was also discovered that for some code-generators it will produce unexpected behaviors having the description inside the allOf.

Which issue(s) this PR fixes:

Fixes #264

Changelog input

[geofencing-subscriptions]: remove `allOf` in `sinkCredential`

@maxl2287 maxl2287 self-assigned this Oct 11, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxl2287 maxl2287 merged commit 6521dff into camaraproject:main Oct 15, 2024
@maxl2287 maxl2287 deleted the fix/remove-all-of-in-sinkcredential branch October 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[geofencing-subscriptions]: Remove "allOf" for sinkCredential in SubscriptionRequest

2 participants