Update location-retrieval with add maxSurface management#262
Merged
Conversation
Add `maxSurface` management
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
alpaycetin74
reviewed
Oct 1, 2024
Fixing linting + adding precision as suggested by @alpaycetin74: `Note: if both `maxAge` and `maxSurface` requirements fail, the system can either send back one or the other error code. `
Fix linting error
jlurien
previously approved these changes
Oct 7, 2024
Collaborator
jlurien
left a comment
There was a problem hiding this comment.
LGTM with minor correction and comment
Co-authored-by: Jose Luis Urien <joseluis.urienpinedo@telefonica.com>
Add a note for maxSurface minimum allowed.
jlurien
reviewed
Dec 17, 2024
Co-authored-by: Jose Luis Urien <joseluis.urienpinedo@telefonica.com>
| * **Max Surface**: Maximum surface in square meters which is accepted by the client for the location retrieval. | ||
|
|
||
| * absence of `maxSurface` means that "any surface size" is acceptable for the client. | ||
| * API implementation could specify in the documentation the `maxSurface` minimum acceptable (for exemple minimun of 10000 square meters allowed). |
Collaborator
There was a problem hiding this comment.
I'd like to propose a minor rewording here, and fixing some typos:
API implementation could specify the minimum acceptable maxSurface in the documentation (for example a minimum of 10000 square meters are allowed).
jlurien
reviewed
Jan 13, 2025
Co-authored-by: Jose Luis Urien <joseluis.urienpinedo@telefonica.com>
jlurien
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
add
maxSurfacemanagementWhich issue(s) this PR fixes:
Fixes #255
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.