Skip to content

203 update and review codeowners and maintainersmd file#204

Merged
hdamker merged 2 commits intomainfrom
203-update-and-review-codeowners-and-maintainersmd-file
Jun 12, 2024
Merged

203 update and review codeowners and maintainersmd file#204
hdamker merged 2 commits intomainfrom
203-update-and-review-codeowners-and-maintainersmd-file

Conversation

@hdamker
Copy link
Contributor

@hdamker hdamker commented Jun 9, 2024

What type of PR is this?

  • subproject management

What this PR does / why we need it:

See #203

Which issue(s) this PR fixes:

Fixes #203

Special notes for reviewers:

@hdamker hdamker added the subproject management Indicating issues with subproject repository or release management process label Jun 9, 2024
@hdamker hdamker requested review from bigludo7 and jlurien as code owners June 9, 2024 21:52
@hdamker hdamker linked an issue Jun 9, 2024 that may be closed by this pull request
Update and review CODEOWNERS and MAINTAINERS.md file #203
Closed
@github-actions
Copy link

github-actions bot commented Jun 9, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.04s
✅ OPENAPI spectral 3 0 5.0s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.76s
✅ YAML yamllint 3 0 0.56s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

bigludo7
bigludo7 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jlurien
jlurien approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the Maintainers list, the current one does not reflect the people actually involved in the subproject, but I guess that is beyond the purpose of the PR.

@hdamker
Copy link
Contributor Author

hdamker commented Jun 12, 2024

Regarding the Maintainers list, the current one does not reflect the people actually involved in the subproject, but I guess that is beyond the purpose of the PR.

@jlurien Half/half: the PR is also meant to trigger the review of the list. But yes, the actual changes could or even should be done in separate PRs.

@hdamker hdamker merged commit 3c7085b into main Jun 12, 2024
@jlurien
Copy link
Collaborator

jlurien commented Jun 13, 2024

Regarding the Maintainers list, the current one does not reflect the people actually involved in the subproject, but I guess that is beyond the purpose of the PR.

@jlurien Half/half: the PR is also meant to trigger the review of the list. But yes, the actual changes could or even should be done in separate PRs.

Understood. Device Location has a quite stable group of contributors but it's not the same people as in the list.

@hdamker hdamker deleted the 203-update-and-review-codeowners-and-maintainersmd-file branch June 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlurien jlurien jlurien approved these changes

@bigludo7 bigludo7 bigludo7 approved these changes

Assignees

No one assigned

Labels

subproject management Indicating issues with subproject repository or release management process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update and review CODEOWNERS and MAINTAINERS.md file

3 participants

@hdamker @jlurien @bigludo7