-
Notifications
You must be signed in to change notification settings - Fork 37
Closed
Labels
Description
Problem description
Commonalities 0.5 asks to have a test for all errors explicitly documented in the spec as relevant.
The following errors defined in location-retrieval.yaml are not explicitly tested by scenarios in location-retrieval.feature:
- 403 PERMISSION_DENIED
- 422 LOCATION_RETRIEVAL_MISSING_IDENTIFIER
- 429 QUOTA_EXCEEDED
- 429 TOO_MANY_REQUESTS
Expected action
Add test scenario if error is considered relevant or remove the error from spec.
- Add test for 403 as this error is mandatory
- Add tests for specific 422 Missing identifier test
- For location-retrieval, 429 is not specifically relevant. Implementations may return 429 for the usual cases even if it is not explicitly documented, so I'm in favor of removing it
- 404 NOT FOUND should be included along with 404 IDENTIFIER_NOT_FOUND in order to be allowed, although for this operation is not expected to be returned so we may remove it
Alternative solution
Additional context
Reactions are currently unavailable