Use identifier instead of identity#90
Merged
eric-murray merged 2 commits intocamaraproject:mainfrom Jan 3, 2025
AxelNennker:AxelNennker-Replace-Identity-by-Identifier
Merged
Use identifier instead of identity#90eric-murray merged 2 commits intocamaraproject:mainfrom AxelNennker:AxelNennker-Replace-Identity-by-Identifier
eric-murray merged 2 commits intocamaraproject:mainfrom
AxelNennker:AxelNennker-Replace-Identity-by-Identifier
Conversation
eric-murray
reviewed
Dec 6, 2024
Collaborator
|
I'm generally happy with this, but IMEI really is "International Mobile Equipment Identity" |
eric-murray
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Use the term "identifier" if an identifier is talked about.
Operators often use the term "identity" when in fact it is an "identifier".
Generally an "identity" and an "identifier" are different.
There a several definitions for "identity" e.g. in OIDF, IETF and W3C e.g. "a collection of claims".
But identity is never used when an identifier is meant.
I think we should avoid operator-speak and use "identifier" if it is an "identifier".