Update Device object handling and description#87
Merged
eric-murray merged 16 commits intocamaraproject:mainfrom Jan 15, 2025
Merged
Update Device object handling and description#87eric-murray merged 16 commits intocamaraproject:mainfrom
eric-murray merged 16 commits intocamaraproject:mainfrom
Conversation
This was referenced Dec 6, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
reviewed
Dec 20, 2024
Kevsy
requested changes
Dec 20, 2024
Collaborator
Kevsy
left a comment
There was a problem hiding this comment.
Added suggestions inline to match the latest common.yaml changes for the error names/descriptions
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
eric-murray
commented
Jan 3, 2025
eric-murray
commented
Jan 3, 2025
Collaborator
Author
|
M3 date is 17th January, so this PR needs to be approved and merged before then so that I can create the release candidate. So, please add any comments you may have before next Wednesday 15th January. Thanks. |
eric-murray
commented
Jan 12, 2025
Collaborator
|
I deleted my comment/suggestion on error handling. Maybe the API Design Guidelines could be clarified. I wanted to make clear that if a valid three-legged access token is used but still the subject cannot be identified then that is a server error (500) of the authorization server. But that is not a topic of this PR. |
Kevsy
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Other APIs passing a Device object do this by passing a separate parameter named
device, even if that is the only object passed in the request. This PR:Which issue(s) this PR fixes:
Fixes # N/A
Special notes for reviewers:
None
Changelog input
Additional documentation
None