Initial Test Definitions for DeviceIdentifier retrieve identifier#72
Merged
eric-murray merged 35 commits intocamaraproject:mainfrom Sep 23, 2024
AxelNennker:patch-1
Merged
Initial Test Definitions for DeviceIdentifier retrieve identifier#72eric-murray merged 35 commits intocamaraproject:mainfrom AxelNennker:patch-1
eric-murray merged 35 commits intocamaraproject:mainfrom
AxelNennker:patch-1
Conversation
Signed-off-by: Axel Nennker <axel.nennker@telekom.de>
eric-murray
reviewed
Aug 5, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Aug 5, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Aug 5, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Aug 5, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Aug 5, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Aug 5, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Aug 5, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Aug 5, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
…ifier_retrieve_identifier.feature Co-authored-by: Eric Murray <eric.murray@vodafone.com>
…etrieve_identifier.feature Co-authored-by: Eric Murray <eric.murray@vodafone.com>
eric-murray
reviewed
Aug 16, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
eric-murray
reviewed
Aug 20, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
| And the resource is "/retrieve-identifier" | ||
| And none of the scopes associated with the access token is device-identifier:retrieve-identifier | ||
| When the HTTPS "POST" request is sent | ||
| And the connection the request is sent over originates from a device with PHONENUMBER1 |
Collaborator
There was a problem hiding this comment.
I'll leave this line in for now, but I don't think this affects the test in any way other than to complicate it. What matters is how the access token is obtained.
This device itself could use client credentials if allowed by regulation, or it could use CIBA if no server involved, or it could use authorisation code flow if a server sent it an appropriate re-direct (in which case, the API call itself would be made by that server and not the device).
All of these options (2-legged token, or 3-legged token obtained using CIBA or authorisation code flow) are also available to a server.
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
…ture Co-authored-by: Eric Murray <eric.murray@vodafone.com>
eric-murray
previously approved these changes
Sep 18, 2024
Collaborator
|
Please provide any additional comments on this PR by end of Friday 20th September, otherwise it will be merged then |
eric-murray
reviewed
Sep 18, 2024
code/Test_definitions/DeviceIdentifier_retrieve_identifier.feature
Outdated
Show resolved
Hide resolved
eric-murray
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Initial test definitions
Fixes #68