Incorporate Commonalities WG recommendations on Simplification of Device object#64
Merged
Kevsy merged 13 commits intocamaraproject:mainfrom Aug 9, 2024
Merged
Conversation
- Add recommended text on "Identifying a device from the access token" - Add 422 error response option - Explicitly define request body as optional
- Fix trailing space
- Rewrite section on handing of device identifiers to clarify that "device" in this context means "mobile subscription identifier", and not the mobile device (UE) itself
- Fix indentation
- Update phoneNumber schema as per current definition in Commonalities
sfnuser
reviewed
Jul 30, 2024
|
|
||
| ### Validation mechanism: | ||
|
|
||
| - The server will extract the mobile subscription identifier (i.e. MSISDN) from the access token, if available. |
Contributor
There was a problem hiding this comment.
Any reason why it has to MSISDN? Should it be (e.g. MSISDN)?
Collaborator
Author
There was a problem hiding this comment.
Well, this is internal implementation that no-one will ever audit, but it will almost certainly be MSISDN or equivalent (such as GPSI). However, I'm happy to change this to "e.g.".
Co-authored-by: Ramesh Shanmugasundaram - Spry Fox Networks <90850565+sfnuser@users.noreply.github.com>
AxelNennker
approved these changes
Jul 30, 2024
Collaborator
AxelNennker
left a comment
There was a problem hiding this comment.
Purely editorial and an improvement
- Update Authorisation and Authentication section following update by Identity & Consent Management - Revise "Validation Mechanism" section to make it more implementation agnostic - Add additional error message codes
- Fix linting errors
Kevsy
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #61
Special notes for reviewers:
Request bodies were already optional
Changelog input
Additional documentation
None