Update CAMARA Mobile Device Identifier API.yaml#55
Merged
Kevsy merged 6 commits intocamaraproject:mainfrom Mar 13, 2024
Merged
Conversation
Update CAMARA Mobile Device Identifier API.yaml
Kevsy
reviewed
Feb 23, 2024
| The API defines a single service endpoint `POST /get-device-identifier`. To call this endpoint, the API consumer must first obtain a valid OAuth2 token from the token endpoint, which is then passed as an Authorization header. The API consumer must also pass at least one of the available mobile subscription identifiers in the body of the request. | ||
| The API defines two service endpoints: | ||
|
|
||
| - `POST /get-identifier` to get details about the specific device being used by a given mobile subscriber, including IMEI / IMEISV and the type of device |
Collaborator
There was a problem hiding this comment.
/get-identifier-> /retrieve-identifier
Kevsy
reviewed
Feb 23, 2024
| The API defines two service endpoints: | ||
|
|
||
| - `POST /get-identifier` to get details about the specific device being used by a given mobile subscriber, including IMEI / IMEISV and the type of device | ||
| - `POST /get-type` to get details only about the type of device being used by a given mobile subscriber |
Collaborator
There was a problem hiding this comment.
/get-type -> /retrieve-type
Kevsy
requested changes
Feb 23, 2024
Collaborator
Kevsy
left a comment
There was a problem hiding this comment.
Two path corrections (see comments) - otherwise a minor comment that 'type' should be explained as meaning 'manufacturer and model' to avoid ambiguity.
Update CAMARA Mobile Device Identifier API.yaml
Collaborator
Author
|
Thanks @Kevsy. Updated. I also added the text explaining that the |
Kevsy
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
retrieve-identifierto obtain individual device detailsretrieve-typeto obtain type of devicelastCheckedfield to indicate when information about device was last confirmed correctWhich issue(s) this PR fixes:
Fixes #47, Fixes #30
Special notes for reviewers:
None
Changelog input
Additional documentation
N/A