Skip to content

Remove IDENTIFIER_MISMATCH error and include optional device property in 200 response#122

Merged
eric-murray merged 21 commits intocamaraproject:mainfrom
eric-murray:eric-murray-patch-3
Jun 17, 2025
Merged

Remove IDENTIFIER_MISMATCH error and include optional device property in 200 response#122
eric-murray merged 21 commits intocamaraproject:mainfrom
eric-murray:eric-murray-patch-3

Conversation

@eric-murray
Copy link
Collaborator

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

Commonalities has removed the IDENTIFIER_MISMATCH error code for Fall25.
This PR:

  • Removes the 422 IDENTIFIER_MISMATCH error code and an option
  • Includes an optional device property of type DeviceResponse in a successful response
  • Adds full examples for 200 responses
  • Updates documentation

Which issue(s) this PR fixes:

Fixes #118

Special notes for reviewers:

This is not a breaking change for the API consumer

Changelog input

 release-note
 - Remove IDENTIFIER_MISMATCH error and include optional device property in 200 response

Additional documentation

None

@eric-murray eric-murray requested a review from Kevsy as a code owner June 13, 2025 15:33
Kevsy
Kevsy previously approved these changes Jun 13, 2025
Copy link
Collaborator

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kevsy
Kevsy previously approved these changes Jun 16, 2025
Copy link
Collaborator

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-murray eric-murray merged commit 1e46cf9 into camaraproject:main Jun 17, 2025
2 checks passed
@eric-murray eric-murray deleted the eric-murray-patch-3 branch June 17, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove IDENTIFIER_MISMATCH error

2 participants