Clarification of Device Object usage#55
Merged
tlohmar merged 2 commits intocamaraproject:mainfrom Aug 19, 2025
Merged
Conversation
SteveV-Vodafone
approved these changes
Jul 14, 2025
Adding a recommendation for not supporting IP addresses as device identifier. Extending the general documentation with a motivation for supporting MSISDNs as device identifier.
Contributor
Author
|
Closed by accident. |
Contributor
Author
|
@hdamker, please check, whether you comments from RC.1 review (PR#34) are addressed. |
eric-murray
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR aligns the device object features to commonalities.
It is also adding a recommendation for not supporting IP addresses as device identifier and extending the general documentation with a motivation for supporting MSISDNs as device identifier.
Which issue(s) this PR fixes:
Fixes #49
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.