Skip to content

Commonalities alignement for connected network type subscription & connected network type#34

Merged
akoshunyadi merged 4 commits intomainfrom
fix33
Jul 10, 2025
Merged

Commonalities alignement for connected network type subscription & connected network type#34
akoshunyadi merged 4 commits intomainfrom
fix33

Conversation

@bigludo7
Copy link
Contributor

@bigludo7 bigludo7 commented Jul 8, 2025

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Following ajustement:

  • Improve sink attribute management (add pattern & 400 error)
  • add (subscription)id as mandatory in SubscriptionAsync schema
  • add missing RFC3339 format description in LastStatusTime attribute

Which issue(s) this PR fixes:

Fixes #33

Special notes for reviewers:

Changelog input

release-note
- add pattern for sink 
- add error 400 INVALID_SINK in the yaml
- add test case for 400 INVALID_SINK
- make subscription id mandatory in async subscription response
- add missing RFC3339 format description for LastStatusTime

Additional documentation

This section can be blank.

docs

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.02s
✅ OPENAPI spectral 2 0 3.54s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.74s
✅ YAML yamllint 2 0 0.67s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@akoshunyadi akoshunyadi merged commit 00b0d97 into main Jul 10, 2025
2 checks passed
@bigludo7 bigludo7 deleted the fix33 branch December 22, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoshunyadi akoshunyadi akoshunyadi approved these changes

@eric-murray eric-murray eric-murray approved these changes

@sachinvodafone sachinvodafone sachinvodafone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Align connected-network-type-subscriptions.yaml with Commonalities

4 participants

@bigludo7 @akoshunyadi @eric-murray @sachinvodafone