Remove IDENTIFIER_MISMATCH from testing artifacts#479
Merged
rartych merged 4 commits intocamaraproject:mainfrom Jun 10, 2025
Merged
Remove IDENTIFIER_MISMATCH from testing artifacts#479rartych merged 4 commits intocamaraproject:mainfrom
rartych merged 4 commits intocamaraproject:mainfrom
Conversation
2 tasks
Contributor
Author
|
@PedroDiez @rartych please review again as I just realised that the wording for the When step was not aligned with the Testing guidelines and the proposal in #470 |
PedroDiez
reviewed
Jun 6, 2025
This was referenced Jun 18, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Error 422 IDENTIFIER_MISMATCH has been deprecated from
Which issue(s) this PR fixes:
Fixes #476
Does this PR introduce a breaking change?
It can be discussed. Previously, clients got an error for the mismatch and now the service may be applied for one of the provided identifiers
Special notes for reviewers:
I have added a line indicating the Commonalities version that the artifact is aligned with. This makes easier to see if an artifact has been updated after certain version of Commonalities.
I have not included alternative scenarios as guidelines do not dictate an specific behaviour for cases where there is a mismatch. Only that an error indicating so must not be returned. Implementations may consider any of the provided identifiers and response may be 2xx or even another error, like 404
Changelog input