Skip to content

Request response definitions and other clarifications in chapter 5 of API Design Guide#450

Merged
rartych merged 9 commits intocamaraproject:mainfrom
rartych:request-response-definitions
Jun 3, 2025
Merged

Request response definitions and other clarifications in chapter 5 of API Design Guide#450
rartych merged 9 commits intocamaraproject:mainfrom
rartych:request-response-definitions

Conversation

@rartych
Copy link
Contributor

@rartych rartych commented Apr 28, 2025

What type of PR is this?

  • enhancement/feature
  • cleanup

What this PR does / why we need it:

Request response definitions and other clarifications in chapter 5 of API Design Guide based on previous review comments

Which issue(s) this PR fixes:

Fixes #445

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Changelog input

Request response definitions and other clarifications in chapter 5 of API Design Guide

PedroDiez added 2 commits May 5, 2025 18:42
ediorial format section 5.7.6
editorial format section 5.8.5 Headers, x-correlator
PedroDiez
PedroDiez previously approved these changes May 5, 2025
Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have made some editorial format updates in Commits:
editorial format section 5.7.6
editorial format section 5.8.5 Headers, x-correlator

Fine with the updates, LGTM in advance

patrice-conil
patrice-conil previously approved these changes May 12, 2025
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clarificagtion on images location

Co-authored-by: tlohmar <Thorsten.Lohmar@ericsson.com>
@rartych rartych dismissed stale reviews from patrice-conil and PedroDiez via 715640f May 20, 2025 11:57
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
@rartych
Copy link
Contributor Author

rartych commented May 20, 2025

@tlohmar
I have accepted your proposal, but removed :

Images should be included in the release branch. This ensures, that images can be updated with API releases.

Since the releases are generated from the main branch, as explained in Release Management wiki, this sentence is redundant for me here.

PedroDiez
PedroDiez previously approved these changes May 20, 2025
Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patrice-conil
patrice-conil previously approved these changes May 20, 2025
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

`description`field: There are no special restrictions specified in CAMARA for the documentation explaining API.
[CommonMark syntax](https://spec.commonmark.org/) may be used for rich text representation.
Images hosted in Github API repository can be embedded in the description, for example:
It is not recommended to link images outsite of the Github API repository, since changes to these images may be outside of control of repository maintainers. Images should be preferably hosted within the API repository within the `documentation/API_documentation/resources` folder. Images should be included in the release branch. This ensures, that images can be updated with API releases.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is not recommended to link images outsite of the Github API repository, since changes to these images may be outside of control of repository maintainers. Images should be preferably hosted within the API repository within the `documentation/API_documentation/resources` folder. Images should be included in the release branch. This ensures, that images can be updated with API releases.
It is not recommended to link images outside of the Github API repository, since changes to these images may be outside of the control of repository maintainers. Images should preferably be hosted within the API repository within the `documentation/API_documentation/resources` folder. Images should be included in the release branch. This ensures that images can be updated with API releases.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos otherwise LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kevsy corrected in 40b4a84

@tlohmar
Copy link
Contributor

tlohmar commented May 20, 2025

@tlohmar I have accepted your proposal, but removed :

Images should be included in the release branch. This ensures, that images can be updated with API releases.

Since the releases are generated from the main branch, as explained in Release Management wiki, this sentence is redundant for me here.

ok, fine when redundant. The important thing is, that people find and follow these instructions.

Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych requested a review from patrice-conil June 2, 2025 08:04
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit aa9498a into camaraproject:main Jun 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarifications related to request body and response definition

5 participants