Remove AUTHENTICATION_REQUIRED error code#429
Merged
rartych merged 4 commits intocamaraproject:mainfrom Apr 29, 2025
Merged
Conversation
PedroDiez
reviewed
Mar 20, 2025
Contributor
PedroDiez
left a comment
There was a problem hiding this comment.
LGTM
Suggest also to align wording in notification-as-cloud-event.yaml
Contributor
|
@eric-murray The conflict is causes by replacing in main branch API-design-guidelines.md with the new document. |
2 tasks
Contributor
Covered in complementary PR #449 |
142ad57 to
e0821c7
Compare
Collaborator
Author
|
Conflicts now resolved |
This was referenced Jun 18, 2025
Blockchain Public Address RC Tranversal WG Aligment Fall 25
camaraproject/BlockchainPublicAddress#99
Merged
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Two 401 error code are currently defined,
UNAUTHENTICATEDandAUTHENTICATION_REQUIRED. These are synonyms, and there is no need to maintain two separate error codes.This PR removes the
AUTHENTICATION_REQUIREDcode from the Commonalities documentation.Which issue(s) this PR fixes:
Fixes #368
Does this PR introduce a breaking change?
Special notes for reviewers:
The official name in the IANA registry is
Unauthorized, but changing the name to that would be a breaking change.Changelog input
Additional documentation
None