Remove sinkCredential from Subscription schema in event-subscription-template.yaml#400
Merged
rartych merged 1 commit intocamaraproject:mainfrom Feb 7, 2025
Merged
Conversation
Contributor
|
LGTM, just editorial comment in Line 14, as we have already reached r2.2 |
Collaborator
Author
This PR won't affect the file version - it is picking that up from the main branch. The usual approach after a (pre-)release is for the person doing the release to immediately raise a new PR to reset all version numbers back to WIP. Once the version number is reset, this PR can be merged and all will be well. |
3 tasks
This was referenced Feb 25, 2025
19 tasks
This was referenced Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Remove sinkCredential from Subscription schema in event-subscription-template.yaml as it cannot be used
Which issue(s) this PR fixes:
Fixes #399
Does this PR introduce a breaking change?
Note: anyone who was returning sink credentials in responses might complain this breaks their implementation, but they should not have been doing that anyway
Special notes for reviewers:
None
Changelog input
Additional documentation
None