Skip to content

Fix testing artifacts for device/phoneNumber#381

Merged
rartych merged 5 commits intocamaraproject:mainfrom
jlurien:corrections-test-arfifacts
Jan 20, 2025
Merged

Fix testing artifacts for device/phoneNumber#381
rartych merged 5 commits intocamaraproject:mainfrom
jlurien:corrections-test-arfifacts

Conversation

@jlurien
Copy link
Contributor

@jlurien jlurien commented Jan 16, 2025

What type of PR is this?

  • correction
  • documentation
  • tests

What this PR does / why we need it:

Fix incorrect sentences and out of date references

Which issue(s) this PR fixes:

Fixes #380

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Test plans copying these scenarios have to be updated

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

rartych
rartych previously approved these changes Jan 16, 2025
Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 editorial comments

LGTM

Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
PedroDiez
PedroDiez previously approved these changes Jan 16, 2025
Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patrice-conil
patrice-conil previously approved these changes Jan 16, 2025
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Eric Murray <eric.murray@vodafone.com>
@jlurien jlurien dismissed stale reviews from patrice-conil and PedroDiez via 63dcdff January 20, 2025 12:36
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Copy link
Contributor

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit 855f6a6 into camaraproject:main Jan 20, 2025
@rartych rartych added correction correction in documentation Spring25 labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

correction correction in documentation Spring25

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Corrections in testing artifacts

6 participants