Skip to content

Improve 403 INVALID_TOKEN_CONTEXT scope/description#377

Merged
rartych merged 2 commits intocamaraproject:mainfrom
bigludo7:main
Jan 22, 2025
Merged

Improve 403 INVALID_TOKEN_CONTEXT scope/description#377
rartych merged 2 commits intocamaraproject:mainfrom
bigludo7:main

Conversation

@bigludo7
Copy link
Collaborator

What type of PR is this?

  • documentation

What this PR does / why we need it:

Improve 403 INVALID_TOKEN_CONTEXT scope/description to corner case the usage of this code.

Which issue(s) this PR fixes:

Fixes #369

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Improve 403 INVALID_TOKEN_CONTEXT scope/description
patrice-conil
patrice-conil previously approved these changes Jan 15, 2025
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych
Copy link
Contributor

rartych commented Jan 15, 2025

I propose to extend Appendix text as indicated by @eric-murray : #369 (comment)

@bigludo7
Copy link
Collaborator Author

I propose to extend Appendix text as indicated by @eric-murray : #369 (comment)

And we do not change the table - right?
No problem for me - I discard this CR?

@rartych
Copy link
Contributor

rartych commented Jan 16, 2025

And we do not change the table - right?

I meant having 2 changes:

  • in the table (more detailed description)
  • in the Appendix (guidelines on the usage)

They seem to be not contradictory :)

@bigludo7
Copy link
Collaborator Author

bigludo7 commented Jan 16, 2025

@rartych Yes perfect !

PedroDiez
PedroDiez previously approved these changes Jan 16, 2025
Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 dismissed stale reviews from PedroDiez and patrice-conil via e6eaa6a January 20, 2025 15:56
@bigludo7
Copy link
Collaborator Author

@rartych @PedroDiez Updated appendix A as suggested by Rafal in today call

Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych requested a review from eric-murray January 21, 2025 10:14
Copy link
Contributor

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarification required on 403 INVALID_TOKEN_CONTEXT vs 422 UNNECESSARY_IDENTIFIER

4 participants