Change guidelines on x-camara-commonalities extension field#375
Merged
rartych merged 5 commits intocamaraproject:mainfrom Jan 20, 2025
Merged
Change guidelines on x-camara-commonalities extension field#375rartych merged 5 commits intocamaraproject:mainfrom
x-camara-commonalities extension field#375rartych merged 5 commits intocamaraproject:mainfrom
Conversation
patrice-conil
previously approved these changes
Jan 13, 2025
Contributor
patrice-conil
left a comment
There was a problem hiding this comment.
LGTM and will certainly be easier to maintain
Contributor
|
LGTM, I suggest to take advantage and also include x-camara-commonalities to https://github.com/camaraproject/Commonalities/blob/main/artifacts/notification-as-cloud-event.yaml |
Contributor
I will open discussion topic for this, to check WG feeling |
eric-murray
approved these changes
Jan 16, 2025
Contributor
Author
|
Conflict resolved |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Change of
x-camara-commonalitiesfield frominfoobject definition, to include only minor version (without patch), as it was hard to maintain in subprojects esp. when Commonalities produce patch release.Which issue(s) this PR fixes:
Fixes #327
Does this PR introduce a breaking change?
Special notes for reviewers:
Removing
x-camara-commonalitiesfield frominfoobject definition in API Design Guidelines can also be considered.Changelog input
Changed guidelines on
x-camara-commonalitiesextension fieldAdditional documentation
This section can be blank.