Update rules when using POST for sensitive data#358
Merged
rartych merged 2 commits intocamaraproject:mainfrom Jan 8, 2025
Merged
Update rules when using POST for sensitive data#358rartych merged 2 commits intocamaraproject:mainfrom
rartych merged 2 commits intocamaraproject:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The existing design guidelines allow the request body to be optional when using
POSTto transfer sensitive data. The changes mandate that the request body be present, even if no parameters need to be sent (e.g. if a 3-legged access token is used). In this case, and empty JSON object must be sent.This change ensures that all APIs passing sensitive data using
POSTadopt a common design pattern.Which issue(s) this PR fixes:
Fixes #247
Does this PR introduce a breaking change?
APIs with an optional
POSTrequest body must now make it mandatory, even if no parameters need to be sentNote: I'm not aware of any current APIs that will be impacted by this change. Device Identifier has a PR which will make the request body mandatory.
Special notes for reviewers:
None
Changelog input
Additional documentation
None