Add enum value for terminationReason attribute in the guideline document#356
Merged
rartych merged 10 commits intocamaraproject:mainfrom Dec 20, 2024
Merged
Add enum value for terminationReason attribute in the guideline document#356rartych merged 10 commits intocamaraproject:mainfrom
terminationReason attribute in the guideline document#356rartych merged 10 commits intocamaraproject:mainfrom
Conversation
Add enum value for `terminationReason` attribut
rartych
reviewed
Dec 11, 2024
rartych
reviewed
Dec 11, 2024
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
PedroDiez
reviewed
Dec 13, 2024
Contributor
PedroDiez
left a comment
There was a problem hiding this comment.
Some editorial comments
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Collaborator
Author
All took in to consideration - Thanks |
PedroDiez
reviewed
Dec 13, 2024
Contributor
rartych
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Add enum value for
terminationReasonattribut by adding a table in our documentation.Which issue(s) this PR fixes:
Fixes #353
Does this PR introduce a breaking change?
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.