Merged
Conversation
…retrieval API (Device Location). Adding a consideration on self-intersecting polygons
This was referenced Oct 17, 2024
4fdd4f8
rartych
previously approved these changes
Nov 22, 2024
patrice-conil
requested changes
Nov 25, 2024
Contributor
patrice-conil
left a comment
There was a problem hiding this comment.
I'm still not a fan of the mappings for the discriminators (I prefer to use the names of the derived classes because it's easier for development) but it will be ok once the typo is fixed
artifacts/CAMARA_common.yaml
Outdated
| minimum: 1 | ||
|
|
||
| Polygon: | ||
| description: Polygonal area. The Polygon should be a simple polygon, i.e. should not intersection itself. |
Contributor
There was a problem hiding this comment.
Fix typo "should not intersect itself"
Typo fixed
rartych
approved these changes
Nov 25, 2024
jlurien
approved these changes
Nov 25, 2024
patrice-conil
approved these changes
Nov 26, 2024
eric-murray
approved these changes
Nov 26, 2024
Collaborator
@rartych From Commonalities perspective it is correct that it isn't breaking change (as there wasn't previously a definition of Area). But for APIs who have already a different definition of Area and need to change over it might have the impact of a breaking change. We might need here a third category. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds a Area Data Type to CAMARA_common.yaml, which is copied from the location-retrieval API (Device Location). Variants of the Data Type are used by the geofencing-subscriptions API (Device Location) and the population-density-data API.
The PR is adding a consideration on self-intersecting polygons.
What type of PR is this?
What this PR does / why we need it:
The Area Data Type is used in multiple CAMARA APIs.
Which issue(s) this PR fixes:
Fixes #242
Does this PR introduce a breaking change?
Special notes for reviewers:
Changelog input
Additional documentation
This section is blank.