Replace broken links with relative links in API-linting-Implementation-Guideline.md#274
Merged
rartych merged 10 commits intocamaraproject:mainfrom Aug 21, 2024
Merged
Replace broken links with relative links in API-linting-Implementation-Guideline.md#274rartych merged 10 commits intocamaraproject:mainfrom
rartych merged 10 commits intocamaraproject:mainfrom
Conversation
Collaborator
|
Looks good to me. Just that instead of |
Collaborator
Author
|
You're right - it does work! This is obviously some "smart" implementation of relative links that my Unix experience has left me poorly prepared for. No doubt this is documented somewhere, but whilst I search for that, I updated the PR with the minimal relative links that still worked. Hopefully this document is now even more "future proof". |
Collaborator
|
PedroDiez
previously approved these changes
Aug 6, 2024
Contributor
PedroDiez
left a comment
There was a problem hiding this comment.
Minor suggestions
LGTM in advance
This was referenced Aug 9, 2024
Merged
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
bigludo7
approved these changes
Aug 19, 2024
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
Approve on behalf of @patrice-conil for Orange team
rartych
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Some links in API-linting-Implementation-Guideline.md are broken. This PR replaces all internal links in the document (broken or otherwise) with relative links.
Which issue(s) this PR fixes:
N/A
Special notes for reviewers:
None
Changelog input
Additional documentation
None