Add 422 UNIDENTIFIABLE_DEVICE error in API-design-guidelines.md table#256
Merged
shilpa-padgaonkar merged 7 commits intocamaraproject:mainfrom Aug 2, 2024
Merged
Conversation
Alignment of table in section 6.2 with Annex A.
Collaborator
Collaborator
|
In addition it would good to add it also to artifacts/CAMARA_common.yaml for consistency. |
UNIDENTIFIABLE_DEVICE added to table in 6.1
Err 422 UNIDENTIFIABLE_DEVICE added
bigludo7
approved these changes
Jul 26, 2024
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
Yes good to manage this also in the Service Exceptions Table.
hdamker
reviewed
Jul 29, 2024
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
PedroDiez
reviewed
Jul 30, 2024
Contributor
PedroDiez
left a comment
There was a problem hiding this comment.
Some editorials for aligment.
Also 422 code can be referenced in table of section 3.2
https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#32-http-response-codes
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
hdamker
reviewed
Jul 30, 2024
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
hdamker
previously approved these changes
Jul 31, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Alignment of table in section 6.2 with Annex A.
Which issue(s) this PR fixes:
Fixes #249
Special notes for reviewers:
To be included in RC.2
Changelog input
Additional documentation