Skip to content

Add SUBSCRIPTION_DELETED as new terminationReason for CloudEvents#238

Merged
rartych merged 1 commit intocamaraproject:mainfrom
maxl2287:feature/add-termination-reason-subscription-deleted
Jun 25, 2024
Merged

Add SUBSCRIPTION_DELETED as new terminationReason for CloudEvents#238
rartych merged 1 commit intocamaraproject:mainfrom
maxl2287:feature/add-termination-reason-subscription-deleted

Conversation

@maxl2287
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

Adds SUBSCRIPTION_DELETED as a new termination reason.

Which issue(s) this PR fixes:

Fixes #237

Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea @maxl2287.

Copy link
Contributor

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding SUBSCRIPTION_DELETED as a terminationReason [event-subscription-template.yaml]

5 participants