Skip to content

[API-Design-Guidelines]: fix typos and internal references, format tables, restructure sentences#229

Merged
rartych merged 14 commits intocamaraproject:mainfrom
maxl2287:fix/typos-corrections
Jul 2, 2024
Merged

[API-Design-Guidelines]: fix typos and internal references, format tables, restructure sentences#229
rartych merged 14 commits intocamaraproject:mainfrom
maxl2287:fix/typos-corrections

Conversation

@maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented Jun 11, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

This PR is a fixing of some style and reference-issues for the API design guidelines

Which issue(s) this PR fixes:

Fixes #232

@maxl2287 maxl2287 changed the title fix typos and internal referencesre, format tables, restructure sentences [API-Design-Guidelines]: fix typos and internal referencesre, format tables, restructure sentences Jun 11, 2024
@maxl2287 maxl2287 changed the title [API-Design-Guidelines]: fix typos and internal referencesre, format tables, restructure sentences [API-Design-Guidelines]: fix typos and internal references, format tables, restructure sentences Jun 11, 2024
patrice-conil
patrice-conil previously approved these changes Jun 11, 2024
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
Thanks @maxl2287 for this great job

Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor editorial comments. Great work!

@maxl2287
Copy link
Contributor Author

@patrice-conil & @PedroDiez updates are done.

@PedroDiez
Copy link
Contributor

Taking advantage in Table contents Max if you can fix this

- [### 6.1 Standardized use of CAMARA error responses](#61-standardized-use-of-camara-error-responses)
- [### 6.2 Error Responses - Device Object](#62-error-responses---device-object)

@maxl2287
Copy link
Contributor Author

@PedroDiez done ✅

patrice-conil
patrice-conil previously approved these changes Jun 17, 2024
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PedroDiez
PedroDiez previously approved these changes Jun 17, 2024
Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych
Copy link
Contributor

rartych commented Jul 2, 2024

Merging as commonly approved (the last commits resolved conficts)

@rartych rartych merged commit 534aeb6 into camaraproject:main Jul 2, 2024
@PedroDiez PedroDiez mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fixing typos and other style-issues in documentation-files

6 participants