Conversation
patrice-conil
previously approved these changes
May 31, 2024
Contributor
patrice-conil
left a comment
There was a problem hiding this comment.
It was missing, so LGTM
Contributor
|
@PedroDiez and @bigludo7 Do we also want to align this to the PR #194 discussion and get rid of 415 error as well? |
Contributor
Author
|
I think it is already aligned Shilpa (let's see also Ludovic's view). My understanding:
|
Contributor
|
@PedroDiez Yes, that's correct, for subscriptions it could still be a possible scenario.. |
…into Alignment_with_PR_198
7df07b0
shilpa-padgaonkar
approved these changes
Jun 3, 2024
rartych
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Align template with #198
Which issue(s) this PR fixes:
Fixes #185 #153
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.