guideline_for_specversion_cloudevent_concept_as_enum#187
Merged
Conversation
bigludo7
approved these changes
Apr 18, 2024
Contributor
|
@rartych : If you do not see any issues as well, could you kindly approve & merge? |
rartych
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
It as been identified in #176 a misaligment in the way the "specversion" field is indicated in API Specs in some Working Gruops.
An aligment is required for any WG to use the same guideline.
Setting this field as an "enum" is foreseen the better option to avoid any misunderstandings both for API design and App developers expectation for its handling. This PR deals with it.
Which issue(s) this PR fixes:
Fixes #176
Special notes for reviewers:
N/A
Changelog input
Additional documentation
N/A