Skip to content

CAMARA_common.yaml bugs and typos fix#174

Merged
shilpa-padgaonkar merged 2 commits intocamaraproject:mainfrom
fernandopradocabrillo:common-file-corrections
Apr 29, 2024
Merged

CAMARA_common.yaml bugs and typos fix#174
shilpa-padgaonkar merged 2 commits intocamaraproject:mainfrom
fernandopradocabrillo:common-file-corrections

Conversation

@fernandopradocabrillo
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction

What this PR does / why we need it:

A few bugs and typos has been detected in the common schemas.

Which issue(s) this PR fixes:

Fixes #173

@rartych
Copy link
Contributor

rartych commented Apr 23, 2024

LGTM
After merging this, let's look at possible changes to API Design Guidelines indicated in #180

Copy link
Contributor

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@shilpa-padgaonkar
Copy link
Contributor

@PedroDiez and @patrice-conil : Could you kindly review

Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@shilpa-padgaonkar
Copy link
Contributor

@PedroDiez @RubenBG7 Could someone from TEF side kindly review and approve so that this PR can be merged?

Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilpa-padgaonkar shilpa-padgaonkar merged commit b16e944 into camaraproject:main Apr 29, 2024
@rartych rartych mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A few bugs and typos in CAMARA_common.yaml

5 participants