This repository was archived by the owner on Mar 10, 2026. It is now read-only.
Conversation
… beyond ideal distance
… in soft repulsion zone
…hardcore repulsion zone
…softening in hardcore repulsion zone
…around ideal distance
…ior in attractive tail and soft repulsion zone
2 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical issue in flat-bottom potential functions where softening was inappropriately applied to severe atomic clashes, potentially underestimating steric penalties. The fix introduces hardcore repulsive boundaries that bypass softening for very short inter-atomic distances.
- Added hardcore repulsive core boundaries to prevent softening of severe clashes
- Updated test cases to reflect the three distinct potential regions (hardcore, soft repulsion, attractive)
- Added specific tests to verify correct behavior in the new hardcore boundary zones
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Corrected the behavior of the flat-bottom potential functions (
apply_flat_bottom_vdwandapply_flat_bottom_hbond) to prevent them from incorrectly softening the energy of severe atomic clashes. The previous implementation applied the softeningdeltaparameter across the entire repulsive region, which could lead to an underestimation of steric penalties. This fix introduces a "hardcore" repulsive boundary, ensuring that only the raw, unsoftened potential is used for very short inter-atomic distances.Changes:
Introduced Hardcore Repulsive Core:
REPULSIVE_CORE_SCALE_FACTORto bothapply_flat_bottom_vdwandapply_flat_bottom_hbond.Updated and Added Unit Tests: