This repository was archived by the owner on Mar 10, 2026. It is now read-only.
Conversation
…ove error handling
18 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
Introduces a large TOML data file containing precomputed rotamer conformations for all standard amino acids under the CHARMM-N force field at 4.8 Å RMSD clustering.
- Adds a single
rmsd-4.8.tomlfile listing multiple rotamer entries per residue type - Each rotamer table (
[[ALA]],[[ARG]], etc.) provides serial, atom name, charge, 3D position, and force field type
Comments suppressed due to low confidence (2)
data/rotamers/charmm-n/rmsd-4.8.toml:1
- File lacks a top-level comment or header explaining the TOML schema, clustering criteria (RMSD 4.8), and how conformers are ordered; consider adding a descriptive comment block at the top.
[[ALA]]
data/rotamers/charmm-n/rmsd-4.8.toml:13
- Multiple
[[ARG]]tables imply distinct rotamers but have no explicit identifier; consider adding acluster_idorindexfield inside each table to distinguish them clearly.
[[ARG]]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces a comprehensive
rotamersmodule designed to load, manage, and apply pre-calculated sidechain conformations. The core component is aRotamerLibrarythat reads rotamer definitions and placement instructions from TOML files. A key aspect of this implementation is that each rotamer is fully parameterized on-the-fly using the existingforcefieldmodule during the loading process. This ensures that rotamers are not just coordinate sets but are immediately ready for accurate energy scoring and conformational sampling within the system.Changes:
Implemented Rotamer Library (
rotamers::library):RotamerLibraryto serve as the central repository for all loaded rotamer conformations.RotamerLibrary::loadto parse rotamer data from a TOML file, mapping conformations to their respectiveResidueType.LibraryLoadErrorenum for handling I/O, parsing, and logical errors during the loading process.Integrated On-the-Fly Parameterization:
parameterize_atomto theParameterizer. This function applies forcefield settings (topology, VDW, delta, etc.) to a singleAtom.RotamerLibraryuses this new method during loading to ensure every atom in every rotamer is fully parameterized and ready for use in energy calculations.Developed a Placement Information System (
rotamers::placement):PlacementInfoandPlacementRegistryto define how a rotamer should be aligned and placed onto a protein backbone.Defined Core Rotamer Data Structures (
rotamers::rotamer):RotamerDataandRotamerAtomDataasserde-compatible structs for deserializing rotamer definitions from files.Rotamerstruct, which holds a collection of fully parameterizedAtomobjects.Established New Module Structure:
rotamersmodule inscream-core.library,placement, androtamer.