-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Copy link
Labels
enhancement ✨New feature or requestNew feature or requestperformance ⚡Performance improvements and code optimizationsPerformance improvements and code optimizations
Milestone
Description
Description:
Introduce three opt-in knobs that can trade exactness for performance or stability tweaks. Defaults remain numerically identical to current behavior (lossless). Hard cutoff only (no pre-baked abstractions for KD-tree). Hydrogen inner iterations must end with a full constrained solve to restore total charge.
Tasks:
-
Hydrogen SCF Toggle (Default: On, Lossless)
- Add
hydrogen_scf: booltoSolverOptions; wire CLI--hydrogen-scf/--no-hydrogen-scfand config key. - When off, keep hydrogen hardness fixed; when on, retain current per-iteration hardness update.
- Add
-
Cutoff Radius (Default: Off, Hard Cutoff, Lossy)
- Add
cutoff_radius: Option<f64>toSolverOptions; wire CLI--cutoff <angstrom>and config key. - Implement hard cutoff in
compute_off_diagonal_rowsusing a cell-list neighbor table (no KD-tree abstractions left unused). - Ensure matrix symmetry and clear documentation that this is a lossy mode with discontinuity at r_cut.
- Add
-
Hydrogen Inner Iterations (Default: 0, Off, Lossy)
- Add
hydrogen_inner_iters: u32toSolverOptions; wire CLI--hydrogen-inner-iters <u32>and config key. - Run up to N inner hydrogen-only steps per global iteration (small fixed cap), then always perform one full constrained solve to restore charge conservation.
- Reuse global tolerance; no extra tol knob; document trade-offs and expected benefit limits.
- Add
-
Docs & Validation
- Update README/USAGE to describe the three knobs, defaults (lossless), and lossy nature of cutoff/inner iters.
- Add/adjust tests to assert defaults remain unchanged; add a sanity test for cutoff path symmetry/constraint hold after the final full solve.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancement ✨New feature or requestNew feature or requestperformance ⚡Performance improvements and code optimizationsPerformance improvements and code optimizations
Type
Projects
Status
Done