Skip to content

370-breaks-under-click830#372

Merged
coordt merged 8 commits intomasterfrom
370-breaks-under-click830
Sep 19, 2025
Merged

370-breaks-under-click830#372
coordt merged 8 commits intomasterfrom
370-breaks-under-click830

Conversation

@coordt
Copy link
Copy Markdown
Member

@coordt coordt commented Sep 19, 2025

From @Kugeleis : To circumvent the current breaking change from click 8.3 I set it to "click<8.3". To make pytest run I had to move dependencies to dev (my uv did not work with group test). I also adjusted some modern API canges for pytest-httpserver.

pre-commit-ci Bot and others added 4 commits September 15, 2025 19:40
@coordt coordt linked an issue Sep 19, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

Version hint: no-release
Current version:
New version (when merged):

Comment ID: Display the version hint-auto-generated

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 19, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-19 13:08 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.38%. Comparing base (91d5eff) to head (68041e8).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files          29       29           
  Lines        1971     1971           
  Branches      207      207           
=======================================
  Hits         1880     1880           
  Misses         65       65           
  Partials       26       26           
Flag Coverage Δ
python-3.10 95.31% <ø> (-0.07%) ⬇️
python-3.11 95.31% <ø> (-0.07%) ⬇️
python-3.12 95.31% <ø> (-0.07%) ⬇️
python-3.13 95.38% <ø> (ø)
python-3.8 95.38% <ø> (ø)
python-3.9 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coordt coordt merged commit 4c80bc1 into master Sep 19, 2025
21 of 22 checks passed
@coordt coordt deleted the 370-breaks-under-click830 branch September 19, 2025 13:08
@Kugeleis
Copy link
Copy Markdown
Contributor

watch out for https://github.com/pallets/click/milestone/28 - Click devs agreed this is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaks under click/8.3.0

2 participants