Skip to content

fix: hotfix/Embed wrong detection#9385

Merged
hariombalhara merged 1 commit intomainfrom
fix/embed-detection
Jun 7, 2023
Merged

fix: hotfix/Embed wrong detection#9385
hariombalhara merged 1 commit intomainfrom
fix/embed-detection

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Jun 7, 2023

What does this PR do?

Regression from #9085

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 8:37am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 8:37am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 8:37am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Jun 7, 2023 8:37am

Copy link
Copy Markdown
Contributor

@JeroenReumkens JeroenReumkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Jun 7, 2023

Current Playwright Test Results Summary

✅ 97 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/07/2023 08:42:34am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 15ff98b

Started: 06/07/2023 08:40:34am UTC

⚠️ Flakes

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
1.49% (5) 5 / 335 runs
failed over last 7 days
19.40% (65) 65 / 335 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully login flow user & logout using dashboard
Retry 1Initial Attempt
0.29% (1) 1 / 345 run
failed over last 7 days
8.41% (29) 29 / 345 runs
flaked over last 7 days

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to disable 2FA
Retry 1Initial Attempt
0% (0) 0 / 343 runs
failed over last 7 days
19.83% (68) 68 / 343 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
7.04% (15) 15 / 213 runs
failed over last 7 days
92.96% (198) 198 / 213 runs
flaked over last 7 days

View Detailed Build Results


@hariombalhara hariombalhara added this pull request to the merge queue Jun 7, 2023
Merged via the queue into main with commit ff75364 Jun 7, 2023
@hariombalhara hariombalhara deleted the fix/embed-detection branch June 7, 2023 08:55
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only 📉 regressing This used to work. Now it doesn't anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants