fix: Credential of type video wrong id on bookingReference#9281
Merged
fix: Credential of type video wrong id on bookingReference#9281
Conversation
CAL-941 Zoom meetings don't get removed from zoom app.
While rejecting or cancelling a booking with event type with zoom. Event should be removed from zoom app too. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
alannnc
commented
Jun 1, 2023
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
No failed tests 🎉 |
…-app-6739-cal-941
zomars
previously approved these changes
Jun 2, 2023
…-app-6739-cal-941
…-app-6739-cal-941
…-app-6739-cal-941
alannnc
commented
Jul 3, 2023
| type: "daily_video", | ||
| key: { apikey: process.env.DAILY_API_KEY }, | ||
| userId: +new Date().getTime(), | ||
| userId: 0, |
Contributor
Author
There was a problem hiding this comment.
Sometimes credentialId or userId should be saved to DB, but prisma will error if tries to save said values. I think we are better off using 0.
@zomars
…-app-6739-cal-941
…-app-6739-cal-941
…-app-6739-cal-941
…-app-6739-cal-941
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6739 #8831
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist