Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 New Page AddedThe following page was added to the bundle from the code in this PR:
Nine Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 24 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/07/2023 07:27:01am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 1bea5be Started: 06/07/2023 07:24:58am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule Tests -- new-booker Should display request reschedule send on bookings/cancelled
Retry 1 • Initial Attempt |
0% (0)0 / 336 runsfailed over last 7 days |
0.30% (1)1 / 336 runflaked over last 7 days |
| const foundToken = await prisma.verificationToken.findFirst({ | ||
| where: { | ||
| token, | ||
| type: "VERIFY_ACCOUNT", | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Find the token that is of type verify account
| const hasCompletedOnboarding = user.completedOnboarding; | ||
|
|
||
| res.redirect(`${WEBAPP_URL}/${hasCompletedOnboarding ? "/event-types" : "/getting-started"}`); |
There was a problem hiding this comment.
If you have already completed onboarding we redirect to event types
Makes the flow much nicer as you dont get a flash of wrong content
| useEffect(() => { | ||
| if (data?.isVerified) { | ||
| router.replace("/getting-started"); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [data?.isVerified]); |
There was a problem hiding this comment.
If you navigate back to this tab after verifying your account we redirect to straight to getting started
There was a problem hiding this comment.
Can we just return a new view that says. "Email is already verified"? Maybe add an CTA that takes you back to the dashboard.
There was a problem hiding this comment.
I dont think it was clear what i meant by this.
if you switch back to this tab after you have verified your email. It navigates you to getting-started. Meaning you dont have to log in or hard refresh
apps/web/pages/signup.tsx
Outdated
| .then(handleErrors) | ||
| .then(async () => { | ||
| telemetry.event(telemetryEventTypes.signup, collectPageParameters()); | ||
| const verifyOrGettingStarted = isEmailVerifyEnabled ? "auth/verify-email" : "getting-started"; |
There was a problem hiding this comment.
Control where the signup redirect takes you - takes into account the featureflag enabled
| const flags = await getFeatureFlagMap(prisma); | ||
|
|
||
| if (!flags["email-verification"]) { | ||
| log.warn("Email verification is disabled - Skipping"); | ||
| return { ok: true, skipped: true }; | ||
| } |
There was a problem hiding this comment.
I'd rather use the getFeatureFlagMap on server-side instead of calling individual features.
|
@sean-brydon If it is the wrong token, should we not show a proper page? Right now, it only shows the json body. Let me know your thoughts. |
You're absolutely right - this is something i missed. Would you mind creating an issue on the back of what you have found while writing the test? |
What does this PR do?
Implements email verification controlled by a feature flag
Loom: https://www.loom.com/share/0b0b9302a0e8499fad1d6444b013337c
Environment: Staging(main branch) / Production
Type of change
How should this be tested?