Skip to content

Revert "Date override fixes (#8330)"#8369

Merged
PeerRich merged 1 commit intomainfrom
fix/revert-override-fixes
Apr 19, 2023
Merged

Revert "Date override fixes (#8330)"#8369
PeerRich merged 1 commit intomainfrom
fix/revert-override-fixes

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli commented Apr 19, 2023

This reverts commit 3ef3284.

What does this PR do?

Fixes # (issue)

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 8:32am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 8:32am

hariombalhara
hariombalhara approved these changes Apr 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it's just a revert.

@PeerRich PeerRich enabled auto-merge (squash) April 19, 2023 08:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Apr 19, 2023 •
edited
Loading

Current Playwright Test Results Summary

✅ 67 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/19/2023 08:42:35am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 1ce436c

Started: 04/19/2023 08:36:58am UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 2 • Retry 1 • Initial Attempt
2.79% (6) 6 / 215 runs
failed over last 7 days
25.58% (55) 55 / 215 runs
flaked over last 7 days
📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt
2.13% (4) 4 / 188 runs
failed over last 7 days
19.15% (36) 36 / 188 runs
flaked over last 7 days

View Detailed Build Results

@PeerRich PeerRich merged commit 20c010f into main Apr 19, 2023
@PeerRich PeerRich deleted the fix/revert-override-fixes branch April 19, 2023 08:43
@p6l-richard p6l-richard mentioned this pull request May 11, 2023
Closed
2 tasks
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hariombalhara hariombalhara hariombalhara approved these changes

Assignees

No one assigned

Labels

core area: core, team members only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarinaWolli @hariombalhara @PeerRich