Skip to content

BugFix: Don't open location dialog on removing location#8085

Merged
PeerRich merged 1 commit intomainfrom
fix/location-dialog-on-remove
Apr 4, 2023
Merged

BugFix: Don't open location dialog on removing location#8085
PeerRich merged 1 commit intomainfrom
fix/location-dialog-on-remove

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Apr 4, 2023

What does this PR do?

Fixes # (issue)
Removing a location opens up dialog

Before:
https://www.loom.com/share/500bfbfc8f5744e79382d4f6676e2d4c

After:
https://www.loom.com/share/6cc37ac65c044841b691fa7da3246460

Regression from #7778

Environment: Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Try adding a new location and removing any existing location.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@hariombalhara hariombalhara requested a review from a team April 4, 2023 14:20
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 2:29pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 2:29pm

@hariombalhara hariombalhara changed the title Dont open location dialog on cross button Dont open location dialog on removing location Apr 4, 2023
@hariombalhara hariombalhara changed the title Dont open location dialog on removing location BugFix: Don't open location dialog on removing location Apr 4, 2023
@hariombalhara hariombalhara requested a review from PeerRich April 4, 2023 14:24
@hariombalhara
Copy link
Copy Markdown
Member Author

@PeerRich can you confirm if I am not breaking any behaviour introduced in #7778

Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 233.33 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 8.44 KB 241.76 KB 69.08% (+/- <0.01%)
/[user] 70.65 KB 303.97 KB 86.85% (+/- <0.01%)
/[user]/[type] 92.39 KB 325.71 KB 93.06% (+/- <0.01%)
/[user]/[type]/embed 92.41 KB 325.74 KB 93.07% (+/- <0.01%)
/[user]/embed 70.71 KB 304.04 KB 86.87% (+/- <0.01%)
/apps 165.86 KB 399.19 KB 114.05% (+/- <0.01%)
/apps/[slug] 187.5 KB 420.83 KB 120.24% (+/- <0.01%)
/apps/categories 148.65 KB 381.98 KB 109.14% (+/- <0.01%)
/apps/categories/[category] 152.54 KB 385.87 KB 110.25% (+/- <0.01%)
/apps/installed/[category] 196.02 KB 429.35 KB 122.67% (+/- <0.01%)
/auth/error 19.24 KB 252.57 KB 72.16% (+/- <0.01%)
/auth/forgot-password 25.63 KB 258.96 KB 73.99% (+/- <0.01%)
/auth/forgot-password/[id] 32.83 KB 266.16 KB 76.05% (+/- <0.01%)
/auth/login 40.1 KB 273.43 KB 78.12% (+/- <0.01%)
/auth/logout 7.56 KB 240.89 KB 68.83% (+/- <0.01%)
/availability 154.15 KB 387.48 KB 110.71% (+/- <0.01%)
/availability/[schedule] 268.72 KB 502.05 KB 143.44% (+/- <0.01%)
/availability/troubleshoot 149.34 KB 382.67 KB 109.33% (+/- <0.01%)
/booking/[uid] 123.62 KB 356.95 KB 101.99% (+/- <0.01%)
/bookings/[status] 272.25 KB 505.58 KB 144.45% (+/- <0.01%)
/d/[link]/[slug] 92.03 KB 325.36 KB 92.96% (+/- <0.01%)
/d/[link]/[slug]/embed 92.06 KB 325.39 KB 92.97% (+/- <0.01%)
/event-types 348.46 KB 581.79 KB 166.22% (🟡 +0.01%)
/event-types/[type] 382.2 KB 615.53 KB 175.86% (+/- <0.01%)
/insights 384.75 KB 618.07 KB 176.59% (+/- <0.01%)
/more 148.28 KB 381.61 KB 109.03% (+/- <0.01%)
/settings/admin 153.73 KB 387.06 KB 110.59% (+/- <0.01%)
/settings/admin/apps 164.92 KB 398.25 KB 113.79% (+/- <0.01%)
/settings/admin/apps/[category] 164.91 KB 398.24 KB 113.78% (+/- <0.01%)
/settings/admin/flags 156.62 KB 389.95 KB 111.41% (+/- <0.01%)
/settings/admin/impersonation 154.01 KB 387.34 KB 110.67% (+/- <0.01%)
/settings/billing 153.84 KB 387.17 KB 110.62% (+/- <0.01%)
/settings/developer/api-keys 182.99 KB 416.32 KB 118.95% (+/- <0.01%)
/settings/developer/webhooks 156.5 KB 389.82 KB 111.38% (+/- <0.01%)
/settings/developer/webhooks/[id] 187.18 KB 420.51 KB 120.15% (+/- <0.01%)
/settings/developer/webhooks/new 187.04 KB 420.37 KB 120.11% (+/- <0.01%)
/settings/my-account/appearance 168.31 KB 401.64 KB 114.75% (+/- <0.01%)
/settings/my-account/calendars 188.03 KB 421.36 KB 120.39% (+/- <0.01%)
/settings/my-account/conferencing 159.63 KB 392.95 KB 112.27% (+/- <0.01%)
/settings/my-account/general 263 KB 496.33 KB 141.81% (+/- <0.01%)
/settings/my-account/profile 271.41 KB 504.73 KB 144.21% (+/- <0.01%)
/settings/security/impersonation 155.88 KB 389.21 KB 111.20% (+/- <0.01%)
/settings/security/password 191.35 KB 424.68 KB 121.34% (+/- <0.01%)
/settings/security/sso 163.58 KB 396.9 KB 113.40% (+/- <0.01%)
/settings/security/two-factor-auth 158.39 KB 391.72 KB 111.92% (+/- <0.01%)
/settings/teams 153.48 KB 386.81 KB 110.52% (+/- <0.01%)
/settings/teams/[id]/appearance 168.33 KB 401.66 KB 114.76% (+/- <0.01%)
/settings/teams/[id]/billing 153.71 KB 387.04 KB 110.58% (+/- <0.01%)
/settings/teams/[id]/members 294.55 KB 527.88 KB 150.82% (+/- <0.01%)
/settings/teams/[id]/profile 266.05 KB 499.38 KB 142.68% (+/- <0.01%)
/settings/teams/[id]/sso 163.67 KB 397 KB 113.43% (+/- <0.01%)
/signup 25.5 KB 258.83 KB 73.95% (+/- <0.01%)
/team/[slug] 72.65 KB 305.97 KB 87.42% (+/- <0.01%)
/team/[slug]/[type] 92.04 KB 325.36 KB 92.96% (+/- <0.01%)
/team/[slug]/[type]/embed 92.07 KB 325.39 KB 92.97% (+/- <0.01%)
/team/[slug]/embed 72.71 KB 306.04 KB 87.44% (+/- <0.01%)
/teams 148.5 KB 381.83 KB 109.09% (+/- <0.01%)
/video/meeting-ended/[uid] 14.67 KB 247.99 KB 70.86% (+/- <0.01%)
/video/meeting-not-started/[uid] 14.3 KB 247.63 KB 70.75% (+/- <0.01%)
/video/no-meeting-found 6.6 KB 239.93 KB 68.55% (+/- <0.01%)
/workflows 161.5 KB 394.82 KB 112.81% (+/- <0.01%)
/workflows/[workflow] 291.27 KB 524.6 KB 149.89% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Apr 4, 2023

Current Playwright Test Results Summary

✅ 66 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/04/2023 02:43:07pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5c92911

Started: 04/04/2023 02:38:26pm UTC

⚠️ Flakes

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
9.64% (16) 16 / 166 runs
failed over last 7 days
26.51% (44) 44 / 166 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich merged commit ba9688a into main Apr 4, 2023
@PeerRich PeerRich deleted the fix/location-dialog-on-remove branch April 4, 2023 14:43
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants