Skip to content

fix: remove box shadow none#8077

Merged
kodiakhq[bot] merged 1 commit intomainfrom
fix/input-focus
Apr 4, 2023
Merged

fix: remove box shadow none#8077
kodiakhq[bot] merged 1 commit intomainfrom
fix/input-focus

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Apr 4, 2023

What does this PR do?

Fixes this bug https://www.loom.com/share/247906747b714aba99b70dc5b4c2cf08

Earlier there was a bug in which you would see blue border in the edit location dialog like this https://stackoverflow.com/questions/69307885/unexpected-blue-border-while-typing-text-react-select/69308190#69308190.

Screenshot 2023-04-04 at 1 09 45 PM

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@Udit-takkar Udit-takkar requested a review from a team April 4, 2023 07:41
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 7:47am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 7:47am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 233.36 KB (-6 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 8.45 KB 241.81 KB 69.09% (+/- <0.01%)
/[user] 70.21 KB 303.57 KB 86.74% (🟢 -0.04%)
/[user]/[type] 91.95 KB 325.31 KB 92.95% (🟢 -0.04%)
/[user]/[type]/embed 91.98 KB 325.34 KB 92.95% (🟢 -0.03%)
/[user]/book 182.89 KB 416.25 KB 118.93% (🟢 -0.03%)
/[user]/embed 70.28 KB 303.64 KB 86.75% (🟢 -0.03%)
/apps 165.42 KB 398.79 KB 113.94% (🟢 -0.04%)
/apps/[slug] 187.06 KB 420.43 KB 120.12% (🟢 -0.03%)
/apps/[slug]/[...pages] 390.87 KB 624.24 KB 178.35% (🟢 -0.03%)
/apps/categories 148.24 KB 381.6 KB 109.03% (🟢 -0.03%)
/apps/categories/[category] 152.1 KB 385.47 KB 110.13% (🟢 -0.03%)
/apps/installed/[category] 195.58 KB 428.94 KB 122.56% (🟢 -0.04%)
/auth/error 19.24 KB 252.6 KB 72.17% (+/- <0.01%)
/auth/forgot-password 25.63 KB 258.99 KB 74.00% (+/- <0.01%)
/auth/forgot-password/[id] 32.83 KB 266.19 KB 76.06% (🟢 -0.01%)
/auth/login 40.1 KB 273.46 KB 78.13% (+/- <0.01%)
/auth/logout 7.56 KB 240.92 KB 68.84% (🟢 -0.01%)
/availability 153.74 KB 387.1 KB 110.60% (🟢 -0.03%)
/availability/[schedule] 268.31 KB 501.67 KB 143.33% (🟢 -0.03%)
/availability/troubleshoot 148.93 KB 382.29 KB 109.23% (🟢 -0.04%)
/booking/[uid] 123.77 KB 357.14 KB 102.04% (🟢 -0.04%)
/bookings/[status] 271.81 KB 505.17 KB 144.33% (🟢 -0.03%)
/d/[link]/[slug] 91.6 KB 324.96 KB 92.85% (🟢 -0.04%)
/d/[link]/[slug]/embed 91.63 KB 324.99 KB 92.85% (🟢 -0.03%)
/d/[link]/book 182.54 KB 415.9 KB 118.83% (🟢 -0.03%)
/event-types 348.02 KB 581.39 KB 166.11% (🟢 -0.03%)
/event-types/[type] 381.79 KB 615.15 KB 175.76% (🟢 -0.04%)
/getting-started/[[...step]] 304 KB 537.37 KB 153.53% (+/- <0.01%)
/insights 383.39 KB 616.75 KB 176.22% (🟢 -0.04%)
/more 147.86 KB 381.23 KB 108.92% (🟢 -0.03%)
/payment/[uid] 60.86 KB 294.22 KB 84.06% (🟢 -0.03%)
/settings/admin 153.32 KB 386.68 KB 110.48% (🟢 -0.03%)
/settings/admin/apps 164.49 KB 397.85 KB 113.67% (🟢 -0.03%)
/settings/admin/apps/[category] 164.48 KB 397.84 KB 113.67% (🟢 -0.04%)
/settings/admin/flags 156.21 KB 389.57 KB 111.31% (🟢 -0.04%)
/settings/admin/impersonation 153.6 KB 386.96 KB 110.56% (🟢 -0.03%)
/settings/billing 153.43 KB 386.79 KB 110.51% (🟢 -0.03%)
/settings/developer/api-keys 182.58 KB 415.94 KB 118.84% (🟢 -0.03%)
/settings/developer/webhooks 156.08 KB 389.45 KB 111.27% (🟢 -0.03%)
/settings/developer/webhooks/[id] 186.77 KB 420.13 KB 120.04% (🟢 -0.03%)
/settings/developer/webhooks/new 186.63 KB 419.99 KB 120.00% (🟢 -0.04%)
/settings/my-account/appearance 167.9 KB 401.26 KB 114.65% (🟢 -0.04%)
/settings/my-account/calendars 187.62 KB 420.98 KB 120.28% (🟢 -0.03%)
/settings/my-account/conferencing 159.21 KB 392.58 KB 112.16% (🟢 -0.03%)
/settings/my-account/general 262.58 KB 495.95 KB 141.70% (🟢 -0.03%)
/settings/my-account/profile 270.99 KB 504.36 KB 144.10% (🟢 -0.03%)
/settings/security/impersonation 155.47 KB 388.83 KB 111.09% (🟢 -0.03%)
/settings/security/password 190.92 KB 424.28 KB 121.22% (🟢 -0.03%)
/settings/security/sso 163.16 KB 396.53 KB 113.29% (🟢 -0.03%)
/settings/security/two-factor-auth 157.98 KB 391.34 KB 111.81% (🟢 -0.03%)
/settings/teams 153.06 KB 386.43 KB 110.41% (🟢 -0.04%)
/settings/teams/[id]/appearance 167.92 KB 401.28 KB 114.65% (🟢 -0.03%)
/settings/teams/[id]/billing 153.3 KB 386.66 KB 110.47% (🟢 -0.03%)
/settings/teams/[id]/members 294.14 KB 527.5 KB 150.72% (🟢 -0.04%)
/settings/teams/[id]/profile 265.63 KB 499 KB 142.57% (🟢 -0.03%)
/settings/teams/[id]/sso 163.25 KB 396.62 KB 113.32% (🟢 -0.03%)
/signup 25.5 KB 258.86 KB 73.96% (+/- <0.01%)
/team/[slug] 72.62 KB 305.98 KB 87.42% (+/- <0.01%)
/team/[slug]/[type] 91.6 KB 324.96 KB 92.85% (🟢 -0.04%)
/team/[slug]/[type]/embed 91.63 KB 324.99 KB 92.86% (🟢 -0.04%)
/team/[slug]/book 182.54 KB 415.91 KB 118.83% (🟢 -0.03%)
/team/[slug]/embed 72.69 KB 306.05 KB 87.44% (+/- <0.01%)
/teams 148.09 KB 381.45 KB 108.99% (🟢 -0.04%)
/video/meeting-ended/[uid] 14.67 KB 248.03 KB 70.87% (🟢 -0.01%)
/video/meeting-not-started/[uid] 14.3 KB 247.66 KB 70.76% (+/- <0.01%)
/video/no-meeting-found 6.6 KB 239.97 KB 68.56% (+/- <0.01%)
/workflows 161.08 KB 394.45 KB 112.70% (🟢 -0.04%)
/workflows/[workflow] 290.83 KB 524.2 KB 149.77% (🟢 -0.03%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Apr 4, 2023

Current Playwright Test Results Summary

✅ 66 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/04/2023 08:05:29am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 0e35cd1

Started: 04/04/2023 07:58:46am UTC

⚠️ Flakes

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user Can cancel the recently created booking and rebook the same timeslot
Retry 1Initial Attempt
2.97% (6) 6 / 202 runs
failed over last 7 days
4.95% (10) 10 / 202 runs
flaked over last 7 days

View Detailed Build Results


@kodiakhq kodiakhq bot merged commit 11789c7 into main Apr 4, 2023
@kodiakhq kodiakhq bot deleted the fix/input-focus branch April 4, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants