Skip to content

Updated Vercel OG to latest + added fallback img#8057

Merged
JeroenReumkens merged 6 commits intomainfrom
feat/og-image-screenshot-fallback
Apr 3, 2023
Merged

Updated Vercel OG to latest + added fallback img#8057
JeroenReumkens merged 6 commits intomainfrom
feat/og-image-screenshot-fallback

Conversation

@JeroenReumkens
Copy link
Copy Markdown
Contributor

What does this PR do?

Updated Vercel OG to latest so we can add a fallback image — and adde…d this fallback image to the screenshot og image.

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

The changes shouldn't effect any module other than /website, but since we updated the Vercel package to a new version, it's good to check the web app as well:

  • Ensure that web app images are still working by checking the OG image of /event-types and /pro/30min.

@JeroenReumkens JeroenReumkens requested a review from a team April 3, 2023 08:56
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 1:42pm
cal-com-web ❌ Failed (Inspect) Apr 3, 2023 1:42pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2023 1:42pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/booking/[uid] 123.63 KB 356.98 KB 101.99% (+/- <0.01%)
/event-types/[type] 383.01 KB 616.35 KB 176.10% (🟢 -0.02%)
/workflows 164.93 KB 398.28 KB 113.79% (🟢 -0.01%)
/workflows/[workflow] 294.1 KB 527.44 KB 150.70% (🟢 -0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the yarn.lock file, looks good to me 💯

@emrysal emrysal enabled auto-merge (squash) April 3, 2023 12:43
@JeroenReumkens JeroenReumkens marked this pull request as draft April 3, 2023 12:45
auto-merge was automatically disabled April 3, 2023 12:45

Pull request was converted to draft

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Apr 3, 2023

Current Playwright Test Results Summary

✅ 66 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/03/2023 01:54:11pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 94d8b61

Started: 04/03/2023 01:48:10pm UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1Initial Attempt
4.12% (8) 8 / 194 runs
failed over last 7 days
23.20% (45) 45 / 194 runs
flaked over last 7 days

View Detailed Build Results


@JeroenReumkens JeroenReumkens marked this pull request as ready for review April 3, 2023 14:03
@JeroenReumkens JeroenReumkens merged commit 99dba73 into main Apr 3, 2023
@JeroenReumkens JeroenReumkens deleted the feat/og-image-screenshot-fallback branch April 3, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants