Fix: Reschedule Reason - Not shown on Success Page as well as wrong label in Email#8053
Fix: Reschedule Reason - Not shown on Success Page as well as wrong label in Email#8053
Conversation
…own on booking success page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 52 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/03/2023 07:35:26am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b802646 Started: 04/03/2023 07:30:07am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
1.82% (3)3 / 165 runsfailed over last 7 days |
32.12% (53)53 / 165 runsflaked over last 7 days |
| ...copyEvent, | ||
| additionalNotes, // Resets back to the additionalNote input and not the override value | ||
| cancellationReason: "$RCH$" + rescheduleReason ? rescheduleReason : "", // Removable code prefix to differentiate cancellation from rescheduling for email | ||
| cancellationReason: "$RCH$" + (rescheduleReason ? rescheduleReason : ""), // Removable code prefix to differentiate cancellation from rescheduling for email |
There was a problem hiding this comment.
"+" has higher precedence then "?". So, rescheduleReason was being sent and not $RCH + rescheduleReason.
What does this PR do?
Fixes # (issue)
cancellationReasonnot being saved. This was causing "Reschedule Reason" to be not show in booking details/success page. This seems to be a regression from Seated booking rescheduling. #5427Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist