Skip to content

Delete canceled workflow emails from scheduled_sends (SendGrid endpoint) #8026

Merged
emrysal merged 6 commits intomainfrom
fix/workflow-notifications
Apr 3, 2023
Merged

Delete canceled workflow emails from scheduled_sends (SendGrid endpoint) #8026
emrysal merged 6 commits intomainfrom
fix/workflow-notifications

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli commented Mar 30, 2023

What does this PR do?

When a scheduled workflow email is canceled in SendGrid the batch_id is still stored in the SendGrid endpoint /v3/user/scheduled_sends. I wrongly assumed that batch_ids were removed automatically when the scheduled date is in the past (I thought I read that somewhere, but I guess I was wrong 🤔) . As there is a limit of entries (which now again was full) we need to delete them ourselves once the scheduled date is in the past.

It also fixes that already verified numbers are shown as verified and don't need to be verified again:
Screenshot 2023-03-30 at 11 36 29

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ❌ Failed (Inspect) Apr 3, 2023 7:44am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 7:44am

@CarinaWolli CarinaWolli marked this pull request as ready for review March 30, 2023 09:42
@CarinaWolli CarinaWolli requested a review from a team March 30, 2023 09:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/workflows/[workflow] 294.11 KB 527.46 KB 150.70% (🟡 +0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Mar 30, 2023

Current Playwright Test Results Summary

✅ 52 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/03/2023 08:00:07am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 311ed01

Started: 04/03/2023 07:54:01am UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1Initial Attempt
4.44% (8) 8 / 180 runs
failed over last 7 days
23.33% (42) 42 / 180 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :), looks good

@emrysal emrysal merged commit caf5918 into main Apr 3, 2023
@emrysal emrysal deleted the fix/workflow-notifications branch April 3, 2023 09:25
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants