fix: disable 2FA switch for non CAL auth identity providers#8021
fix: disable 2FA switch for non CAL auth identity providers#8021
CAL auth identity providers#8021Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 66 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/02/2023 10:30:53am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 4dff27b Started: 04/02/2023 10:22:30am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 2 • Retry 1 • Initial Attempt |
2.03% (3)3 / 148 runsfailed over last 7 days |
32.43% (48)48 / 148 runsflaked over last 7 days |
📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user Can cancel the recently created booking and rebook the same timeslot
Retry 1 • Initial Attempt |
2.91% (5)5 / 172 runsfailed over last 7 days |
2.33% (4)4 / 172 runsflaked over last 7 days |
| {!isCalProvider && ( | ||
| <Alert | ||
| severity="neutral" | ||
| message="Two-Factor authentication can be enabled only for email and password authentication." |
There was a problem hiding this comment.
approved but we should really translate this :)
|
|
||
| if (isLoading) return <SkeletonLoader />; | ||
|
|
||
| const isCalProvider = user?.identityProvider === "CAL"; |
There was a problem hiding this comment.
NIT: will we need this in the future? maybe worth moving into lib
What does this PR do?
after:
Type of change