Merged
Conversation
alannnc
commented
Apr 4, 2023
| </div> | ||
| <small className="block text-center text-gray-600"> | ||
| {t("looking_for_more_analytics")} | ||
| {t("looking_for_more_insights")} |
Contributor
Author
There was a problem hiding this comment.
Style or text changes.
alannnc
commented
Apr 4, 2023
| colors={["blue"]} | ||
| valueFormatter={valueFormatter} | ||
| /> | ||
| )} |
Contributor
Author
There was a problem hiding this comment.
Added logic components to display if data is empty.
alannnc
commented
Apr 4, 2023
|
|
||
| if (!isSuccess || !startDate || !endDate || !teamId || data?.empty) return null; | ||
| if (isLoading) { | ||
| return <LoadingKPICards categories={categories} />; |
alannnc
commented
Apr 4, 2023
| <path | ||
| className="opacity-75" | ||
| fill="currentColor" | ||
| d="M4 12a8 8 0 018-8V0C5.373 0 0 5.373 0 12h4zm2 5.291A7.962 7.962 0 014 12H0c0 3.042 1.135 5.824 3 7.938l3-2.647z" |
Contributor
Author
There was a problem hiding this comment.
Component that can be reused inside every card from insights while loading.
alannnc
commented
Apr 4, 2023
| setSelectedUserId(parsedUserId); | ||
| setSelectedTeamId(null); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Cleaning url and context state.
alannnc
commented
Apr 4, 2023
| import dayjs from "@calcom/dayjs"; | ||
| import { hashPassword } from "@calcom/features/auth/lib/hashPassword"; | ||
|
|
||
| const shuffle = ( |
Contributor
Author
There was a problem hiding this comment.
Moved to a reusable function.
alannnc
commented
Apr 4, 2023
| }, | ||
| }); | ||
|
|
||
| if (userSingleEventsAdmin.length === 0 && userSingleEvents.length === 0) { |
Contributor
Author
There was a problem hiding this comment.
I added bookins and event types that belong to team members but they don't belong to the team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://www.loom.com/share/30c75cb2e5234b2dac6fc0af896d1bfa
Environment: Staging(main branch)
Type of change
How should this be tested?
Checklist
Validate we have everything in this comment:
#7922 (comment)