Skip to content

fix: remove validateSlug Query#8015

Merged
emrysal merged 3 commits intomainfrom
fix/team-err-message
Apr 3, 2023
Merged

fix: remove validateSlug Query#8015
emrysal merged 3 commits intomainfrom
fix/team-err-message

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Mar 29, 2023

What does this PR do?

Fixes Cleaning up create team form

Screen.Recording.2023-03-29.at.11.40.42.PM.mov

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@Udit-takkar Udit-takkar requested a review from zomars as a code owner March 29, 2023 18:11
@Udit-takkar Udit-takkar requested review from a team March 29, 2023 18:11
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 2:07pm
cal-com-web ❌ Failed (Inspect) Apr 3, 2023 2:07pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 2:07pm

Comment on lines -595 to -601
.query(async ({ ctx, input }) => {
const team = await ctx.prisma.team.findFirst({
where: {
slug: input.slug,
},
});
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are already running this query in viewer.teams.create

const { slug, name, logo } = input;

const nameCollisions = await ctx.prisma.team.findFirst({
const slugCollisions = await ctx.prisma.team.findFirst({
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are checking checking slug here not name. both can be different

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 233.34 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Forty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 167.2 KB 400.55 KB 114.44% (🟢 -0.01%)
/apps/[slug] 190.92 KB 424.27 KB 121.22% (🟢 -0.01%)
/apps/[slug]/[...pages] 392.18 KB 625.52 KB 178.72% (🟢 -0.01%)
/apps/categories 152.1 KB 385.45 KB 110.13% (🟢 -0.02%)
/apps/categories/[category] 155.97 KB 389.31 KB 111.23% (🟢 -0.01%)
/apps/installed/[category] 196.95 KB 430.3 KB 122.94% (🟢 -0.01%)
/availability 155.41 KB 388.75 KB 111.07% (🟢 -0.01%)
/availability/[schedule] 272.17 KB 505.51 KB 144.43% (🟢 -0.01%)
/availability/troubleshoot 152.79 KB 386.13 KB 110.32% (🟢 -0.01%)
/booking/[uid] 123.63 KB 356.98 KB 101.99% (+/- <0.01%)
/bookings/[status] 272.49 KB 505.83 KB 144.52% (🟢 -0.01%)
/event-types 349.14 KB 582.48 KB 166.42% (🟢 -0.01%)
/event-types/[type] 383.02 KB 616.37 KB 176.10% (🟢 -0.01%)
/insights 387.25 KB 620.6 KB 177.31% (🟢 -0.01%)
/more 151.73 KB 385.07 KB 110.02% (🟢 -0.01%)
/settings/admin 157.18 KB 390.53 KB 111.58% (🟢 -0.01%)
/settings/admin/apps 165.87 KB 399.21 KB 114.06% (🟢 -0.01%)
/settings/admin/apps/[category] 165.85 KB 399.2 KB 114.06% (🟢 -0.02%)
/settings/admin/flags 160.08 KB 393.42 KB 112.41% (🟢 -0.02%)
/settings/admin/impersonation 157.47 KB 390.81 KB 111.66% (🟢 -0.01%)
/settings/billing 157.29 KB 390.64 KB 111.61% (🟢 -0.01%)
/settings/developer/api-keys 186.45 KB 419.79 KB 119.94% (🟢 -0.01%)
/settings/developer/webhooks 159.95 KB 393.29 KB 112.37% (🟢 -0.01%)
/settings/developer/webhooks/[id] 190.64 KB 423.98 KB 121.14% (🟢 -0.01%)
/settings/developer/webhooks/new 190.5 KB 423.84 KB 121.10% (🟢 -0.01%)
/settings/my-account/appearance 171.24 KB 404.59 KB 115.60% (🟢 -0.02%)
/settings/my-account/calendars 191.48 KB 424.83 KB 121.38% (🟢 -0.01%)
/settings/my-account/conferencing 163.11 KB 396.45 KB 113.27% (🟢 -0.01%)
/settings/my-account/general 266.45 KB 499.79 KB 142.80% (🟢 -0.01%)
/settings/my-account/profile 274.27 KB 507.62 KB 145.03% (🟢 -0.01%)
/settings/security/impersonation 159.33 KB 392.68 KB 112.19% (🟢 -0.01%)
/settings/security/password 192.63 KB 425.97 KB 121.71% (🟢 -0.02%)
/settings/security/sso 167.03 KB 400.37 KB 114.39% (🟢 -0.01%)
/settings/security/two-factor-auth 161.85 KB 395.19 KB 112.91% (🟢 -0.01%)
/settings/teams 156.93 KB 390.27 KB 111.51% (🟢 -0.02%)
/settings/teams/[id]/appearance 171.27 KB 404.61 KB 115.60% (🟢 -0.01%)
/settings/teams/[id]/billing 157.16 KB 390.51 KB 111.57% (🟢 -0.01%)
/settings/teams/[id]/members 297.26 KB 530.61 KB 151.60% (🟢 -0.01%)
/settings/teams/[id]/profile 269.48 KB 502.83 KB 143.66% (🟢 -0.01%)
/settings/teams/[id]/sso 167.12 KB 400.47 KB 114.42% (🟢 -0.01%)
/settings/teams/new 92.69 KB 326.04 KB 93.15% (🟢 -0.01%)
/teams 151.94 KB 385.29 KB 110.08% (🟢 -0.01%)
/workflows 164.95 KB 398.29 KB 113.80% (🟢 -0.01%)
/workflows/[workflow] 294.07 KB 527.41 KB 150.69% (🟢 -0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Mar 29, 2023

Current Playwright Test Results Summary

✅ 52 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/03/2023 02:17:05pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 00fe2a4

Started: 04/03/2023 02:11:00pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can add multiple organizer address
Retry 1Initial Attempt
2.20% (4) 4 / 182 runs
failed over last 7 days
30.77% (56) 56 / 182 runs
flaked over last 7 days

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity tests Date Overrides
Retry 1Initial Attempt
2.90% (6) 6 / 207 runs
failed over last 7 days
7.73% (16) 16 / 207 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tweak, merging 🙏

@emrysal emrysal merged commit 73afb03 into main Apr 3, 2023
@emrysal emrysal deleted the fix/team-err-message branch April 3, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants