Conversation
CAL-1341 Change reschedule booking flow handling of old event
Is your proposal related to a problem?Currently we are deleting a rescheduled event, this causes the event to 404 when a link is opened that has since been rescheduled. Instead of a hard delete we should set the event as cancelled so a "This event has been cancelled" message can be shown. We may even want to add a new booking status to identity rescheduled events. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Sixty-two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 66 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/30/2023 04:52:54pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: e3df7fd Started: 03/30/2023 04:47:38pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
2.25% (4)4 / 178 runsfailed over last 7 days |
32.02% (57)57 / 178 runsflaked over last 7 days |
|
Some type errors, but personally I wouldn't vote for implementing BookingStatus.RESCHEDULED as an additional status. - soft delete should set the previous booking to CANCELLED and create a new one with fromReschedule. |
| "user_needs_to_confirm_or_reject_booking": "{{user}} still needs to confirm or reject the booking.", | ||
| "user_needs_to_confirm_or_reject_booking_recurring": "{{user}} still needs to confirm or reject each booking of the recurring meeting.", | ||
| "meeting_is_scheduled": "This meeting is scheduled", | ||
| "meeting_is_rescheduled": "This meeting is rescheduled", |
There was a problem hiding this comment.
Similarly, we don't really need a special message for rescheduled bookings, just show cancel message
|
@emrysal pushed some changes |
CarinaWolli
left a comment
There was a problem hiding this comment.
e2e test is failing:
let's remove that line and check if the status of the rescheduled booking is CANCELLED
…-handling-of-old-event
…-handling-of-old-event
What does this PR do?
Fixes #7946. rather than deleting a rescheduled this PR aims to soft delete the rescheduled bookings.
Type of change