Skip to content

feat: Google Tag Manager (GTM) App#7952

Merged
hariombalhara merged 2 commits intocalcom:mainfrom
Earli-Days:google-tag-manager
Apr 4, 2023
Merged

feat: Google Tag Manager (GTM) App#7952
hariombalhara merged 2 commits intocalcom:mainfrom
Earli-Days:google-tag-manager

Conversation

@StefanFlorea00
Copy link
Copy Markdown
Contributor

@StefanFlorea00 StefanFlorea00 commented Mar 27, 2023

What does this PR do?

There is an existing app for Google Analytics 4. We created an app that works in the same way but with Google Tag Manger integration.

Environment: Staging(main branch) / Production

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Install the app
  • Add the app to an event, fill in the Tracking ID with a GTM container ID
  • Ensure that the GTM script is visible on the booking page (in inspect elements)
  • Preview and test if GTM events are fired successfully using the tagmanager

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

TODO:

  • copy changes and screenshot review @Jaibles @PeerRich

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 233.27 KB (🟡 +12 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user] 103.71 KB 336.98 KB 96.28% (🟡 +0.09%)
/[user]/[type] 92.17 KB 325.44 KB 92.98% (🟡 +0.09%)
/[user]/[type]/embed 92.2 KB 325.46 KB 92.99% (🟡 +0.09%)
/[user]/book 183.77 KB 417.03 KB 119.15% (🟡 +0.09%)
/[user]/embed 103.78 KB 337.04 KB 96.30% (🟡 +0.09%)
/apps 167.5 KB 400.76 KB 114.50% (🟡 +0.09%)
/apps/[slug] 191.22 KB 424.48 KB 121.28% (🟡 +0.09%)
/apps/[slug]/[...pages] 392.63 KB 625.89 KB 178.83% (🟡 +0.09%)
/apps/categories 152.36 KB 385.63 KB 110.18% (🟡 +0.08%)
/apps/categories/[category] 156.26 KB 389.52 KB 111.29% (🟡 +0.09%)
/apps/installed/[category] 197.36 KB 430.63 KB 123.04% (🟡 +0.09%)
/auth/setup 79.48 KB 312.75 KB 89.36% (+/- <0.01%)
/availability 155.67 KB 388.94 KB 111.13% (🟡 +0.08%)
/availability/[schedule] 272.43 KB 505.7 KB 144.48% (🟡 +0.09%)
/availability/troubleshoot 153.05 KB 386.32 KB 110.38% (🟡 +0.08%)
/booking/[uid] 123.88 KB 357.15 KB 102.04% (🟡 +0.09%)
/bookings/[status] 272.7 KB 505.96 KB 144.56% (🟡 +0.09%)
/d/[link]/[slug] 91.82 KB 325.08 KB 92.88% (🟡 +0.09%)
/d/[link]/[slug]/embed 91.85 KB 325.11 KB 92.89% (🟡 +0.09%)
/d/[link]/book 183.42 KB 416.69 KB 119.05% (🟡 +0.09%)
/event-types 349.63 KB 582.9 KB 166.54% (🟡 +0.09%)
/event-types/[type] 383.25 KB 616.51 KB 176.15% (🟡 +0.10%)
/getting-started/[[...step]] 303.08 KB 536.35 KB 153.24% (🟡 +0.01%)
/insights 386.53 KB 619.8 KB 177.09% (🟡 +0.08%)
/more 151.99 KB 385.25 KB 110.07% (🟡 +0.09%)
/payment/[uid] 61.1 KB 294.36 KB 84.10% (🟡 +0.09%)
/settings/admin 157.44 KB 390.71 KB 111.63% (🟡 +0.08%)
/settings/admin/apps 166.15 KB 399.42 KB 114.12% (🟡 +0.09%)
/settings/admin/apps/[category] 166.14 KB 399.4 KB 114.12% (🟡 +0.08%)
/settings/admin/flags 160.34 KB 393.6 KB 112.46% (🟡 +0.08%)
/settings/admin/impersonation 157.73 KB 390.99 KB 111.71% (🟡 +0.08%)
/settings/billing 157.56 KB 390.82 KB 111.66% (🟡 +0.09%)
/settings/developer/api-keys 186.71 KB 419.98 KB 119.99% (🟡 +0.09%)
/settings/developer/webhooks 160.05 KB 393.31 KB 112.38% (🟡 +0.08%)
/settings/developer/webhooks/[id] 190.9 KB 424.17 KB 121.19% (🟡 +0.08%)
/settings/developer/webhooks/new 190.76 KB 424.03 KB 121.15% (🟡 +0.08%)
/settings/my-account/appearance 171.52 KB 404.79 KB 115.65% (🟡 +0.09%)
/settings/my-account/calendars 191.75 KB 425.01 KB 121.43% (🟡 +0.08%)
/settings/my-account/conferencing 163.32 KB 396.59 KB 113.31% (🟡 +0.08%)
/settings/my-account/general 266.71 KB 499.98 KB 142.85% (🟡 +0.08%)
/settings/my-account/profile 274.61 KB 507.87 KB 145.11% (🟡 +0.08%)
/settings/security/impersonation 159.6 KB 392.86 KB 112.25% (🟡 +0.08%)
/settings/security/password 192.91 KB 426.18 KB 121.77% (🟡 +0.08%)
/settings/security/sso 167.29 KB 400.56 KB 114.44% (🟡 +0.09%)
/settings/security/two-factor-auth 162.05 KB 395.32 KB 112.95% (🟡 +0.08%)
/settings/teams 157.19 KB 390.46 KB 111.56% (🟡 +0.08%)
/settings/teams/[id]/appearance 171.54 KB 404.81 KB 115.66% (🟡 +0.08%)
/settings/teams/[id]/billing 157.42 KB 390.69 KB 111.63% (🟡 +0.08%)
/settings/teams/[id]/members 297.43 KB 530.7 KB 151.63% (🟡 +0.08%)
/settings/teams/[id]/profile 269.81 KB 503.08 KB 143.74% (🟡 +0.08%)
/settings/teams/[id]/sso 167.38 KB 400.65 KB 114.47% (🟡 +0.08%)
/team/[slug] 105.9 KB 339.16 KB 96.90% (🟡 +0.01%)
/team/[slug]/[type] 91.82 KB 325.09 KB 92.88% (🟡 +0.09%)
/team/[slug]/[type]/embed 91.85 KB 325.12 KB 92.89% (🟡 +0.09%)
/team/[slug]/book 183.42 KB 416.69 KB 119.05% (🟡 +0.09%)
/team/[slug]/embed 105.96 KB 339.23 KB 96.92% (🟡 +0.01%)
/teams 152.21 KB 385.47 KB 110.14% (🟡 +0.08%)
/workflows 165.1 KB 398.37 KB 113.82% (🟡 +0.08%)
/workflows/[workflow] 294.32 KB 527.59 KB 150.74% (🟡 +0.09%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the correct image here that demoes that the App is working. cc @PeerRich

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2023

@StefanFlorea00 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 6:22PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 6:22PM (UTC)

@hariombalhara hariombalhara merged commit f0e15d7 into calcom:main Apr 4, 2023
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Apr 4, 2023

/tip 50

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Apr 4, 2023

👉 @PeerRich: Click here to proceed

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Apr 4, 2023

@StefanFlorea00: You just got a $50.00 tip! 👉 Complete your Algora onboarding to collect your payment.

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Apr 5, 2023

🎉🎈 @StefanFlorea00 has been awarded $50.00! 🎈🎊

@algora-pbc algora-pbc bot added the 💰 Rewarded Rewarded bounties on Algora.io label Apr 5, 2023
@StefanFlorea00 StefanFlorea00 deleted the google-tag-manager branch June 19, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💰 Rewarded Rewarded bounties on Algora.io

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants